Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #114 #118

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Fix for #114 #118

merged 11 commits into from
Jul 17, 2024

Conversation

nickjbrowning
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Apr 29, 2024

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

@Luthaf
Copy link
Contributor

Luthaf commented Apr 30, 2024

The code looks good, we can merge once CI is happy

Luthaf
Luthaf previously requested changes May 3, 2024
sphericart-torch/include/sphericart/torch.hpp Outdated Show resolved Hide resolved
@nickjbrowning nickjbrowning requested a review from Luthaf May 3, 2024 11:05
@frostedoyster
Copy link
Collaborator

@nickjbrowning @Luthaf what's the status of this?

@Luthaf
Copy link
Contributor

Luthaf commented Jul 17, 2024

This was waiting on CI to be fixed, after what I can do a quick review and merge!

@nickjbrowning
Copy link
Collaborator Author

should be good for review @Luthaf

@Luthaf Luthaf merged commit 40f277e into main Jul 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants